Change output format #68 - #69
Merged
Merged
Conversation
TG1999
force-pushed
the
output_format_change
branch
5 times, most recently
from
September 28, 2022 19:08
8f9935f to
9193a5f
Compare
pombredanne
requested changes
Sep 30, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
LGTM with a minor nit!
You still need a changelog entry and some doc that explains the new format and its key changes
Reference: #68 Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
output_format_change
branch
from
September 30, 2022 15:07
9193a5f to
c33e256
Compare
Make write_output sleek by passing output as a parameter instead of computing output in the function Bump the version to 0.7.2 Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
mnonnenmacher
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Oct 5, 2022
As no dependencies are installed anymore there is no need to create a virtual environment. The Python binary from the path is now used to get metadata from setup.py. This might temporarily cause issues if the setup.py is not compatible with this Python version, but this will soon be fixed once this data can be retrieved from the python-inspector output (this will be available once [1] is released). [1]: aboutcode-org/python-inspector#69 Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
mnonnenmacher
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Oct 5, 2022
As no dependencies are installed anymore there is no need to create a virtual environment. The Python binary from the path is now used to get metadata from setup.py. This might temporarily cause issues if the setup.py is not compatible with this Python version, but this will soon be fixed once this data can be retrieved from the python-inspector output (this will be available once [1] is released). [1]: aboutcode-org/python-inspector#69 Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
mnonnenmacher
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Oct 10, 2022
As no dependencies are installed anymore there is no need to create a virtual environment. The Python binary from the path is now used to get metadata from setup.py. This might temporarily cause issues if the setup.py is not compatible with this Python version, but this will soon be fixed once this data can be retrieved from the python-inspector output (this will be available once [1] is released). [1]: aboutcode-org/python-inspector#69 Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
mnonnenmacher
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Oct 10, 2022
As no dependencies are installed anymore there is no need to create a virtual environment. The Python binary from the path is now used to get metadata from setup.py. This might temporarily cause issues if the setup.py is not compatible with this Python version, but this will soon be fixed once this data can be retrieved from the python-inspector output (this will be available once [1] is released). [1]: aboutcode-org/python-inspector#69 Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
mnonnenmacher
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Oct 11, 2022
As no dependencies are installed anymore there is no need to create a virtual environment. The Python binary from the path is now used to get metadata from setup.py. This might temporarily cause issues if the setup.py is not compatible with this Python version, but this will soon be fixed once this data can be retrieved from the python-inspector output (this will be available once [1] is released). [1]: aboutcode-org/python-inspector#69 Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
mnonnenmacher
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Oct 11, 2022
As no dependencies are installed anymore there is no need to create a virtual environment. The Python binary from the path is now used to get metadata from setup.py. This might temporarily cause issues if the setup.py is not compatible with this Python version, but this will soon be fixed once this data can be retrieved from the python-inspector output (this will be available once [1] is released). [1]: aboutcode-org/python-inspector#69 Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: #68
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com